hplip: fix plugin fetch#391529
Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom Mar 23, 2025
Merged
Conversation
HP now returns 403 for unrecognized user-agents, set it to Firefox prefix (bare 'Mozilla/5.0' wasn't enough). Also adds `plugin` as a derivation parameter instead of a closed-over binding so it's possible to `overrideAttrs` it (e.g. point at internal mirror or vendor the file).
93f793b to
05c60b3
Compare
3 tasks
Kitt3120
approved these changes
Mar 23, 2025
3 tasks
13 tasks
nixpkgs-ci bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
(cherry picked from commit 60b7c9f)
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HP now returns 403 for unrecognized user-agents:
This change sets fetch user-agent to Firefox prefix (bare 'Mozilla/5.0' wasn't enough).
Also adds plugin source as a second source instead of a closed-over binding so it's possible to read and override it from outside (e.g. point at internal mirror or vendor the file).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.